third_party/WebKit/Source/core/paint/SVGClipPainter.h - Issue 2078343005: Fix positioning of CSS reference clips in composited layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGClipPainter.h

Issue 2078343005: Fix positioning of CSS reference clips in composited layers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add virtual expectation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGClipPainter.h

diff --git a/third_party/WebKit/Source/core/paint/SVGClipPainter.h b/third_party/WebKit/Source/core/paint/SVGClipPainter.h

index ce901646010d5cfd46918706775f665b23863f8d..e1da3baf850603740e1b9ff62d3c29170dd5b73c 100644

--- a/third_party/WebKit/Source/core/paint/SVGClipPainter.h

+++ b/third_party/WebKit/Source/core/paint/SVGClipPainter.h

@@ -30,12 +30,13 @@ public:

// FIXME: Filters are also stateful resources that could benefit from having their state managed

// on the caller stack instead of the current hashmap. We should look at refactoring these

// into a general interface that can be shared.

- bool prepareEffect(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext&, ClipperState&);

+ bool prepareEffect(const LayoutObject&, const FloatRect&, const FloatRect&, const FloatPoint&, GraphicsContext&, ClipperState&);

void finishEffect(const LayoutObject&, GraphicsContext&, ClipperState&);

private:

// Return false if there is a problem drawing the mask.

- bool drawClipAsMask(GraphicsContext&, const LayoutObject&, const FloatRect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect, const AffineTransform&);

+ bool drawClipAsMask(GraphicsContext&, const LayoutObject&, const FloatRect& targetBoundingBox,

+ const FloatRect& targetPaintInvalidationRect, const AffineTransform&, const FloatPoint&);

LayoutSVGResourceClipper& m_clip;

};