Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2078343003: [Mac] Call base::i18n::InitializeICU in infoplist_strings_tool. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Call base::i18n::InitializeICU in infoplist_strings_tool. BUG=616830 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/284f4b2c6eedeed928463691221ef23a89168f2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
4 years, 6 months ago (2016-06-20 20:30:59 UTC) #1
Mark Mentovai
LGTM
4 years, 6 months ago (2016-06-20 20:33:35 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/284f4b2c6eedeed928463691221ef23a89168f2b Cr-Commit-Position: refs/heads/master@{#400779}
4 years, 6 months ago (2016-06-20 21:13:13 UTC) #4
Robert Sesek
4 years, 6 months ago (2016-06-20 21:18:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
284f4b2c6eedeed928463691221ef23a89168f2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698