Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2078333004: Revert of Reenable WebGL Image Chromium. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable WebGL Image Chromium. (patchset #1 id:1 of https://codereview.chromium.org/2085573002/ ) Reason for revert: Causes WebGL2 conformance test errors on some devices. https://bugs.chromium.org/p/chromium/issues/detail?id=620067 Original issue's description: > [Reland 1] Reenable WebGL Image Chromium. > > The feature was disabled because of two bugs. Both have since been fixed. > > BUG=617249, 581777 > TBR=piman@chromium.org, kbr@chromium.org > > Committed: https://crrev.com/f5c146230498ed8e7c5b24d2361c0551415e368d > Cr-Commit-Position: refs/heads/master@{#400709} TBR=kbr@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617249, 581777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
Created Revert of Reenable WebGL Image Chromium.
4 years, 6 months ago (2016-06-20 20:56:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078333004/1
4 years, 6 months ago (2016-06-20 20:57:09 UTC) #3
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 6 months ago (2016-06-20 20:58:06 UTC) #5
erikchen
On 2016/06/20 20:58:06, commit-bot: I haz the power wrote: > Internal error: failed to checkout. ...
4 years, 6 months ago (2016-06-20 21:50:55 UTC) #6
erikchen
4 years, 6 months ago (2016-06-20 21:51:19 UTC) #7
On 2016/06/20 21:50:55, erikchen wrote:
> On 2016/06/20 20:58:06, commit-bot: I haz the power wrote:
> > Internal error: failed to checkout. Please try again.
> 
> This CL had trouble landing. I wanted to disable the WebGL2 test anyways, so
> instead I'm going to do that directly and close this CL.

see https://codereview.chromium.org/2087463003/.

Powered by Google App Engine
This is Rietveld 408576698