Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2078273002: PPC/s390: [builtins] Introduce proper Float64Cos and Float64Sin. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Introduce proper Float64Cos and Float64Sin. Port c781e83194031b337f8eafb42588a2e3d7440782 Port 4d4eb611111b0216d702fe7fd2e61d31875998e9 Original commit message: Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. Unify Atanh, Cbrt and Expm1 as exports from flibm. R=bmeurer@chromium.org, mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5086, v8:5118, v8:5103 LOG=N Committed: https://crrev.com/f7e7c32da2ed2cafa712912f4bee33970f62e866 Cr-Commit-Position: refs/heads/master@{#37083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 3 chunks +23 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 3 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-19 21:43:09 UTC) #1
JoranSiu
On 2016/06/19 21:43:09, JaideepBajwa wrote: > PTAL lgtm
4 years, 6 months ago (2016-06-20 02:52:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078273002/1
4 years, 6 months ago (2016-06-20 03:07:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 03:28:19 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 03:31:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7e7c32da2ed2cafa712912f4bee33970f62e866
Cr-Commit-Position: refs/heads/master@{#37083}

Powered by Google App Engine
This is Rietveld 408576698