Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2078243002: Revert of [Turbofan] Clean up register allocator and verifier code. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
bbudge, Mircea Trofin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Turbofan] Clean up register allocator and verifier code. (patchset #1 id:1 of https://codereview.chromium.org/2081443002/ ) Reason for revert: [Sheriff] Speculative revert. Looks like this lets a few ignition+turbofan tests time out under tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10171 Original issue's description: > [Turbofan] Clean up register allocator and verifier code. > > - Improves RegisterName display in register allocator. > - Removes GetFixedRegisters method in preparation for having multiple fp > reg types. > - Clean up some verifier code. > > LOG=N > BUG=v8:4124 > > Committed: https://crrev.com/d99e1ab60557e86b62ccc6c91514e817c0df370d > Cr-Commit-Position: refs/heads/master@{#37076} TBR=mtrofin@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/a17f3d248e247cda8e51344ce6f426e93ab97284 Cr-Commit-Position: refs/heads/master@{#37077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -38 lines) Patch
M src/compiler/register-allocator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 8 chunks +27 lines, -30 lines 0 comments Download
M src/compiler/register-allocator-verifier.h View 4 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Turbofan] Clean up register allocator and verifier code.
4 years, 6 months ago (2016-06-19 07:35:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078243002/1
4 years, 6 months ago (2016-06-19 07:35:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-19 07:36:19 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-19 07:36:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a17f3d248e247cda8e51344ce6f426e93ab97284
Cr-Commit-Position: refs/heads/master@{#37077}

Powered by Google App Engine
This is Rietveld 408576698