Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: third_party/opus/BUILD.gn

Issue 2078223002: Add a dedicated "optimize_speed" config to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update w/ review feedback, call it "optimize_speed" instead and make it cross-platform Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/arm.gni") 5 import("//build/config/arm.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 # If fixed point implementation shall be used (otherwise float). 8 # If fixed point implementation shall be used (otherwise float).
9 use_opus_fixed_point = current_cpu == "arm" || current_cpu == "arm64" 9 use_opus_fixed_point = current_cpu == "arm" || current_cpu == "arm64"
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 110
111 if (is_posix && !is_android) { 111 if (is_posix && !is_android) {
112 # Suppress a warning given by opus_decoder.c that tells us 112 # Suppress a warning given by opus_decoder.c that tells us
113 # optimizations are turned off. 113 # optimizations are turned off.
114 cflags += [ "-Wno-#pragma-messages" ] 114 cflags += [ "-Wno-#pragma-messages" ]
115 } 115 }
116 116
117 if (!is_debug && is_posix && 117 if (!is_debug && is_posix &&
118 (current_cpu == "arm" || current_cpu == "arm64")) { 118 (current_cpu == "arm" || current_cpu == "arm64")) {
119 configs -= [ "//build/config/compiler:default_optimization" ] 119 configs -= [ "//build/config/compiler:default_optimization" ]
120 configs += [ "//build/config/compiler:optimize_max" ] 120
121 # TODO(crbug.com/621335) Rework this so that we don't have the confusion
122 # between "optimize_speed" and "optimize_max".
123 configs += [ "//build/config/compiler:optimize_speed" ]
121 } 124 }
122 125
123 if (use_opus_fixed_point) { 126 if (use_opus_fixed_point) {
124 sources += gypi_values.opus_fixed_sources 127 sources += gypi_values.opus_fixed_sources
125 128
126 defines += [ "FIXED_POINT" ] 129 defines += [ "FIXED_POINT" ]
127 130
128 include_dirs += [ "src/silk/fixed" ] 131 include_dirs += [ "src/silk/fixed" ]
129 } else { 132 } else {
130 sources += gypi_values.opus_float_sources 133 sources += gypi_values.opus_float_sources
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 configs -= [ "//build/config/compiler:chromium_code" ] 290 configs -= [ "//build/config/compiler:chromium_code" ]
288 configs += [ 291 configs += [
289 "//build/config/compiler:no_chromium_code", 292 "//build/config/compiler:no_chromium_code",
290 ":opus_test_config", 293 ":opus_test_config",
291 ] 294 ]
292 295
293 deps = [ 296 deps = [
294 ":opus", 297 ":opus",
295 ] 298 ]
296 } 299 }
OLDNEW
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698