Storage manager: Add conditional messages for disk low situation and update design.

Storage manager: Add conditional messages for disk low situation and update design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0
Cr-Commit-Position: refs/heads/master@{#401199}

[fukino, 2016-06-18 02:45:49]

Description was changed from

==========
Storage manager: Add conditional messages for disk low situation and update
design.

BUG=
==========

to

==========
Storage manager: Add conditional messages for disk low situation and update
design.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-06-20 16:59:48]

Description was changed from

==========
Storage manager: Add conditional messages for disk low situation and update
design.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Storage manager: Add conditional messages for disk low situation and update
design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when
space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-06-20 17:03:11]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org

[fukino, 2016-06-20 17:03:12]

Dan, could you take a look?

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/options.html (right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/options.html:54: <link rel="stylesheet"
href="chrome://resources/css/roboto.css">
Loading roboto.css to use Roboto's medium weight on storage manager. Is it OK to
use the medium weight in options?

[Dan Beam, 2016-06-21 01:39:56]

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/storage_manager.html (right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/storage_manager.html:32: <div
id="storage-bar-progress"></div>
why not use a <progress> element?

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/options.html (right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/options.html:54: <link rel="stylesheet"
href="chrome://resources/css/roboto.css">
On 2016/06/20 17:03:12, fukino wrote:
> Loading roboto.css to use Roboto's medium weight on storage manager. Is it OK
to
> use the medium weight in options?

why are you using roboto in old options?

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
(right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:36: //
Threshold to show a message indicatiog space is critically low (512 MB).
indicatiog -> indicating

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:37: const
int64_t kSpaceCriticallyLowBytes = 512LL << 20;
512 * 1024 * 1024 

would probably be more explanatory, IMO

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:40: const
int64_t kSpaceLowBytes = 1LL << 30;
same here:

1 * 1024 * 1024 * 1024

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:168:
size_stat.SetBoolean("isSpaceLow", *available_size < kSpaceLowBytes);
nit: maybe make an enum?

[fukino, 2016-06-21 22:21:50]

Thank you for the review! Please take another look.

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/storage_manager.html (right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/storage_manager.html:32: <div
id="storage-bar-progress"></div>
On 2016/06/21 01:39:55, Dan Beam wrote:
> why not use a <progress> element?

Done.
I didn't know the progress element. Thanks!

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/options.html (right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/options.html:54: <link rel="stylesheet"
href="chrome://resources/css/roboto.css">
On 2016/06/21 01:39:55, Dan Beam wrote:
> On 2016/06/20 17:03:12, fukino wrote:
> > Loading roboto.css to use Roboto's medium weight on storage manager. Is it
OK
> to
> > use the medium weight in options?
> 
> why are you using roboto in old options?

IIUC, Chrome OS uses Roboto as system font, and old options uses Roboto too.

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
(right):

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:36: //
Threshold to show a message indicatiog space is critically low (512 MB).
On 2016/06/21 01:39:56, Dan Beam wrote:
> indicatiog -> indicating

Done.

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:37: const
int64_t kSpaceCriticallyLowBytes = 512LL << 20;
On 2016/06/21 01:39:56, Dan Beam wrote:
> 512 * 1024 * 1024 
> 
> would probably be more explanatory, IMO

Done.

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:40: const
int64_t kSpaceLowBytes = 1LL << 30;
On 2016/06/21 01:39:56, Dan Beam wrote:
> same here:
> 
> 1 * 1024 * 1024 * 1024

Done.

https://codereview.chromium.org/2078153002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:168:
size_stat.SetBoolean("isSpaceLow", *available_size < kSpaceLowBytes);
On 2016/06/21 01:39:56, Dan Beam wrote:
> nit: maybe make an enum?

Done.

[Dan Beam, 2016-06-22 00:11:27]

can you use .svgs instead of .pngs?

see: ui/webui/resources/images/warning.svg (copy and just change the fill color,
IMO)

https://codereview.chromium.org/2078153002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
(right):

https://codereview.chromium.org/2078153002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:201: }
nit: no curlies

[Dan Beam, 2016-06-22 00:13:58]

if you use svg you can probably just change the HTML to <img
src="a-file-in-the-same-dir.svg"> and enable grit "flattening" (i.e.
flattenhtml="true" in the grd file that includes your .html file)

either way, lgtm not to slow you down

[fukino, 2016-06-22 03:12:24]

Thank you!
I replaced pngs with svgs, and use them in <img> tag. (they are flattened.)

https://codereview.chromium.org/2078153002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
(right):

https://codereview.chromium.org/2078153002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc:201: }
On 2016/06/22 00:11:27, Dan Beam wrote:
> nit: no curlies

Done.

[fukino, 2016-06-22 03:13:04]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-06-22 03:13:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2078153002/#ps60001
(title: "Use svg.")

[commit-bot: I haz the power, 2016-06-22 03:13:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078153002/60001

[commit-bot: I haz the power, 2016-06-22 03:55:30]

Description was changed from

==========
Storage manager: Add conditional messages for disk low situation and update
design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when
space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Storage manager: Add conditional messages for disk low situation and update
design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when
space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-22 03:55:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-22 03:58:59]

Description was changed from

==========
Storage manager: Add conditional messages for disk low situation and update
design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when
space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Storage manager: Add conditional messages for disk low situation and update
design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when
space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0
Cr-Commit-Position: refs/heads/master@{#401199}
==========

[commit-bot: I haz the power, 2016-06-22 03:59:00]

Patchset 4 (id:??) landed as
https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0
Cr-Commit-Position: refs/heads/master@{#401199}