third_party/WebKit/Source/core/html/HTMLPlugInElement.h - Issue 2078143002: Make plugin elements return false from canStartSelection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2078143002: Make plugin elements return false from canStartSelection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix readonly-disabled-text-selection for changes in r401155 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/readonly-disabled-text-selection.html ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

index 77957923a4302a62789a8fc9543f42a1c0967ad9..fd8eb0da11436ab44201db2025dda719692b6837 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

@@ -104,6 +104,7 @@ private:

// Node functions:

bool canContainRangeEndPoint() const override { return false; }

+ bool canStartSelection() const override;

bool willRespondToMouseClickEvents() final;

void defaultEventHandler(Event*) final;

void attach(const AttachContext& = AttachContext()) final;