Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/api/alarms/alarms_api.cc

Issue 2078103002: Make AlarmManager::Alarm non copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/alarms/alarms_api.h ('k') | extensions/browser/api/alarms/alarms_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/alarms/alarms_api.cc
diff --git a/extensions/browser/api/alarms/alarms_api.cc b/extensions/browser/api/alarms/alarms_api.cc
index edd207bdb061b8bc66ee6e4170a1826d8cbb0163..483a5d2a5ec96cc4a0d678453462bb002b65f2ca 100644
--- a/extensions/browser/api/alarms/alarms_api.cc
+++ b/extensions/browser/api/alarms/alarms_api.cc
@@ -115,9 +115,10 @@ bool AlarmsCreateFunction::RunAsync() {
: alarms_api_constants::kReleaseDelayMinimum)) *
kSecondsPerMinute;
- Alarm alarm(alarm_name, params->alarm_info, granularity, clock_->Now());
+ std::unique_ptr<Alarm> alarm(
+ new Alarm(alarm_name, params->alarm_info, granularity, clock_->Now()));
AlarmManager::Get(browser_context())
- ->AddAlarm(extension_id(), alarm,
+ ->AddAlarm(extension_id(), std::move(alarm),
base::Bind(&AlarmsCreateFunction::Callback, this));
return true;
@@ -158,8 +159,8 @@ bool AlarmsGetAllFunction::RunAsync() {
void AlarmsGetAllFunction::Callback(const AlarmList* alarms) {
std::unique_ptr<base::ListValue> alarms_value(new base::ListValue());
if (alarms) {
- for (const Alarm& alarm : *alarms)
- alarms_value->Append(alarm.js_alarm->ToValue());
+ for (const std::unique_ptr<Alarm>& alarm : *alarms)
+ alarms_value->Append(alarm->js_alarm->ToValue());
}
SetResult(std::move(alarms_value));
SendResponse(true);
« no previous file with comments | « extensions/browser/api/alarms/alarms_api.h ('k') | extensions/browser/api/alarms/alarms_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698