extensions/browser/api/alarms/alarms_api.h - Issue 2078103002: Make AlarmManager::Alarm non copyable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarms_api.h

Issue 2078103002: Make AlarmManager::Alarm non copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/alarms/alarms_api.h

diff --git a/extensions/browser/api/alarms/alarms_api.h b/extensions/browser/api/alarms/alarms_api.h

index 837da909620d60d1051f2ff9ae8a810284e412ab..7ffacae255e330b1495b1b0f75f04af018001608 100644

--- a/extensions/browser/api/alarms/alarms_api.h

+++ b/extensions/browser/api/alarms/alarms_api.h

@@ -15,7 +15,7 @@ class Clock;

namespace extensions {

struct Alarm;

-typedef std::vector<Alarm> AlarmList;

+typedef std::vector<std::unique_ptr<Alarm>> AlarmList;

Devlin 2016/06/18 01:50:19 nitty nit: update to using.

lazyboy 2016/06/18 02:42:11 Done.

class AlarmsCreateFunction : public AsyncExtensionFunction {

public: