Issue 20781007: Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20781007: Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi (Closed)

Created:
7 years, 4 months ago by oliv

Modified:
7 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi Additionally refactor the X87Stack tracking BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16246

Patch Set 1 : #

Total comments: 3

Patch Set 2 : faster -0 check #

Patch Set 3 : address review #

Patch Set 4 : add fst without p #

Patch Set 5 : rebase #

Patch Set 6 : add a test that was still missing in cl #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -162 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2 3 4	4 chunks	+59 lines, -12 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	10 chunks	+207 lines, -124 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2 3 4	3 chunks	+3 lines, -11 lines	0 comments	Download
A +	test/mjsunit/regress/regress-x87.js	View	1 2 3 4 5	1 chunk	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

I like this change. Lgtm with some nits. https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode4902 src/ia32/lithium-codegen-ia32.cc:4902: } ...

7 years, 4 months ago (2013-08-01 11:19:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #6 manually as r16246.

Expand Messages | Collapse Messages