Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: mojo/edk/system/dispatcher.h

Issue 2078043002: Make Dispatcher::AddAwakable(), etc. always set *signals_state (if signals_state is non-null). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/data_pipe.cc ('k') | mojo/edk/system/local_message_pipe_endpoint.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/dispatcher.h
diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h
index 6369f04cdab0e313bc8bc4462674192cccf3d17f..0646f7bef997dae5d7b9b084e9f9cbe54f17c1e9 100644
--- a/mojo/edk/system/dispatcher.h
+++ b/mojo/edk/system/dispatcher.h
@@ -193,8 +193,8 @@ class Dispatcher : public util::RefCountedThreadSafe<Dispatcher> {
// also be woken up when it becomes impossible for the object to ever satisfy
// |signals| with a suitable error status.
//
- // If |signals_state| is non-null, on *failure* |*signals_state| will be set
- // to the current handle signals state (on success, it is left untouched).
+ // If |signals_state| is non-null, |*signals_state| will be set to the current
+ // handle signals state.
//
// Any awakable that's added must either eventually be removed (using
// |RemoveAwakable()| or |RemoveAwakableWithContext()|, below). If an
@@ -214,8 +214,7 @@ class Dispatcher : public util::RefCountedThreadSafe<Dispatcher> {
uint64_t context,
HandleSignalsState* signals_state);
// Like |AddAwakable()|, but in the |MOJO_RESULT_ALREADY_EXISTS| case still
- // adds the awakable (|MOJO_RESULT_ALREADY_EXISTS| will still be returned and
- // |*signals_state| will still be set if |signals_state| is non-null).
+ // adds the awakable (|MOJO_RESULT_ALREADY_EXISTS| will still be returned).
MojoResult AddAwakableUnconditional(Awakable* awakable,
MojoHandleSignals signals,
uint64_t context,
« no previous file with comments | « mojo/edk/system/data_pipe.cc ('k') | mojo/edk/system/local_message_pipe_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698