Introduce build configuration to summary building.

Introduce build configuration to summary building.

Options are largely unused but are in line with what is specified in CLI to support `build_mode` bringing us a step closer to a unified summary builder and in the short term to a provisional API that should work for Flutter SDK generation experiments in the next alpha release.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/9a75f18e47f49c52cd6fb4dc091895b4066307a2

[pquitslund, 2016-06-17 19:48:03]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Paul Berry, 2016-06-17 19:57:51]

lgtm

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_file_builder.dart (right):

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:63: /**
Nit: add a blank line here.

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:64: * Whether to create
summaries using only ASTs, i.e. don't perform resolution.
Technically, creating summaries from ASTs performs resolution; it just does it
in a different way that doesn't require creating a full element model.  Consider
changing to something like: "Whether to create summaries directly from ASTs,
i.e. don't create a full element model."

[Brian Wilkerson, 2016-06-17 20:09:09]

lgtm

[pquitslund, 2016-06-17 20:37:32]

Description was changed from

==========
Introduce build configuration to summary building.

Options are largely unused but are in line with what is specified in CLI to
support `build_mode` bringing us a step closer to a unified summary builder and
in the short term to a provisional API that should work for Flutter SDK
generation experiments in the next alpha release.

BUG=
==========

to

==========
Introduce build configuration to summary building.

Options are largely unused but are in line with what is specified in CLI to
support `build_mode` bringing us a step closer to a unified summary builder and
in the short term to a provisional API that should work for Flutter SDK
generation experiments in the next alpha release.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9a75f18e47f49c52cd6fb4dc091895b4066307a2
==========

[pquitslund, 2016-06-17 20:37:34]

Committed patchset #1 (id:1) manually as
9a75f18e47f49c52cd6fb4dc091895b4066307a2 (presubmit successful).

[pquitslund, 2016-06-17 20:47:32]

Thanks!

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_file_builder.dart (right):

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:63: /**
On 2016/06/17 19:57:51, Paul Berry wrote:
> Nit: add a blank line here.

Done.

https://codereview.chromium.org/2078033002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:64: * Whether to create
summaries using only ASTs, i.e. don't perform resolution.
On 2016/06/17 19:57:51, Paul Berry wrote:
> Technically, creating summaries from ASTs performs resolution; it just does it
> in a different way that doesn't require creating a full element model. 
Consider
> changing to something like: "Whether to create summaries directly from ASTs,
> i.e. don't create a full element model."

Done.