wm: Fix override-redirect window stacking bug.

wm: Fix override-redirect window stacking bug.

This fixes an issues where we'd often stack override-redirect
windows' actors too low initially, which could result in regular
windows' actors incorrectly being drawn above them later.  The
problem is described in more detail at http://crosbug.com/3451.

This change also adds a basic implementation of GetDebugString()
to MockCompositor::Actor and includes layer stacking reference
points' X IDs in their actors' names (making debugging a bit
easier).

BUG=chromium-os:3451
TEST=added

[Daniel Erat, 2010-05-21 22:14:45]

Sorry for all of these reviews.  This is the last one in the series!

[sky, 2010-05-21 22:36:03]

LGTM

http://codereview.chromium.org/2078031/diff/1/3
File src/platform/window_manager/mock_compositor.cc (right):

http://codereview.chromium.org/2078031/diff/1/3#newcode64
src/platform/window_manager/mock_compositor.cc:64: out += "  ";
I believe out.resize(ident_level, ' ') does this for you.

[Daniel Erat, 2010-05-21 23:16:55]

Thanks, updated it to use assign() (which seems a bit more accurate
than resize() here).  I made a trivial change to make us handle bogus
stacking attempts gracefully in non-debug mode and crash in debug mode
and am committing now.

On Fri, May 21, 2010 at 3:36 PM,  <sky@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/2078031/diff/1/3
> File src/platform/window_manager/mock_compositor.cc (right):
>
> http://codereview.chromium.org/2078031/diff/1/3#newcode64
> src/platform/window_manager/mock_compositor.cc:64: out += "  ";
> I believe out.resize(ident_level, ' ') does this for you.
>
> http://codereview.chromium.org/2078031/show
>