media/audio/audio_manager.cc - Issue 2077983003: Intiialize AudioManager and related class lazily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_manager.cc

Issue 2077983003: Intiialize AudioManager and related class lazily (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check if StartHangTimer() is called earlier Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/audio_manager.cc

diff --git a/media/audio/audio_manager.cc b/media/audio/audio_manager.cc

index fae54bfd166dcf263aaf1bcb158fb5254590c7db..f8f62ccb741f12d927143a6cfcf4a0c683c9167a 100644

--- a/media/audio/audio_manager.cc

+++ b/media/audio/audio_manager.cc

@@ -62,7 +62,8 @@ class AudioManagerHelper : public base::PowerObserver {

void StartHangTimer(

scoped_refptr<base::SingleThreadTaskRunner> monitor_task_runner) {

- CHECK(!monitor_task_runner_);

+ if (monitor_task_runner_)

+ return;

CHECK(!audio_task_runner_);

monitor_task_runner_ = std::move(monitor_task_runner);

audio_task_runner_ = AudioManager::Get()->GetTaskRunner();