Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2077843002: Service worker: Remove unneeded early stop in FinishRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix a callsiet Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 621f6cf92e14b334b98fdfcb68dca7571e8840d2..2dfb353ff41e98824ffc4e44d8826cd82fab4c68 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -547,11 +547,6 @@ bool ServiceWorkerVersion::FinishRequest(int request_id, bool was_handled) {
TRACE_EVENT_ASYNC_END1("ServiceWorker", "ServiceWorkerVersion::Request",
request, "Handled", was_handled);
custom_requests_.Remove(request_id);
- if (is_redundant()) {
- // The stop should be already scheduled, but try to stop immediately, in
- // order to release worker resources soon.
- StopWorkerIfIdle();
- }
return true;
}
@@ -603,8 +598,6 @@ void ServiceWorkerVersion::AddStreamingURLRequestJob(
void ServiceWorkerVersion::RemoveStreamingURLRequestJob(
const ServiceWorkerURLRequestJob* request_job) {
streaming_url_request_jobs_.erase(request_job);
- if (is_redundant())
- StopWorkerIfIdle();
}
void ServiceWorkerVersion::AddListener(Listener* listener) {
« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698