Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207783002: Omit "int" when using "unsigned" modifier (Closed)

Created:
6 years, 9 months ago by gnana
Modified:
6 years, 9 months ago
CC:
blink-reviews, kouhei+svg_chromium.org, jamesr, eae+blinkwatch, fs, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, Nils Barth (inactive), krit, caseq+blink_chromium.org, Nate Chapin, arv+blink, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, abarth-chromium, danakj, marja+watch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, loislo+blink_chromium.org, zoltan1, sof, jbroman, lushnikov+blink_chromium.org, Raymond Toy, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Omit "int" when using "unsigned" modifier Omitting "int" when using "unsigned" modifier as per Blink Coding Style Guidelines. BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170023

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -163 lines) Patch
M Source/bindings/v8/ScriptFunctionCall.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptHeapSnapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptHeapSnapshot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParserValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/HashTools.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeRanges.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/style/StyleDeprecatedFlexibleBoxData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleDeprecatedFlexibleBoxData.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathFunctions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/CheckedInt.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/KeyCodeConversionAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TraceEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioPullFIFO.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/DenormalDisabler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 51 chunks +51 lines, -51 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-encoders/skia/JPEGImageEncoder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/text/UnicodeRange.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebCache.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/WebInputEventFactoryGtk.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/x11/WebScreenInfoFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/StringExtrasTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/TypeTraits.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/Uint32Array.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/wtf/text/AtomicString.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/IntegerToStringConversion.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/StringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/WTFString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/coverage/tracer.c View 1 chunk +9 lines, -9 lines 0 comments Download
M public/platform/WebGraphicsContext3D.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gnana
Please have a look.
6 years, 9 months ago (2014-03-21 08:25:22 UTC) #1
Erik Corry
LGTM
6 years, 9 months ago (2014-03-21 10:33:36 UTC) #2
gnana
6 years, 9 months ago (2014-03-24 05:55:57 UTC) #3
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 9 months ago (2014-03-24 15:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/207783002/20001
6 years, 9 months ago (2014-03-24 15:01:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 15:12:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-24 15:12:41 UTC) #7
eseidel
lgtm
6 years, 9 months ago (2014-03-26 05:49:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/207783002/20001
6 years, 9 months ago (2014-03-26 05:49:31 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 06:02:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 170023

Powered by Google App Engine
This is Rietveld 408576698