Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2988)

Unified Diff: ui/base/ime/input_method_base.cc

Issue 2077783002: Make limitations for input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Blacklist extension window. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_base.cc
diff --git a/ui/base/ime/input_method_base.cc b/ui/base/ime/input_method_base.cc
index 282b6c4f9ad5434ab6eef5d541eea02a8245d12b..89016d8bc8764e1fdb0db73f3372f66bf278d052 100644
--- a/ui/base/ime/input_method_base.cc
+++ b/ui/base/ime/input_method_base.cc
@@ -199,8 +199,17 @@ void InputMethodBase::DeleteSurroundingText(int32_t offset, uint32_t length) {}
void InputMethodBase::SendKeyEvent(KeyEvent* event) {
sending_key_event_ = true;
+ key_events_for_test.push_back(new KeyEvent(*event));
Devlin 2016/06/22 16:33:12 This never gets cleared in production, right? And
Azure Wei 2016/06/23 02:45:23 Fixed with adding test flag in InputMethod.
DispatchKeyEvent(event);
sending_key_event_ = false;
}
+InputMethod* InputMethodBase::GetInputMethod() {
+ return this;
+}
+
+std::vector<ui::KeyEvent*> InputMethodBase::GetKeyEventsForTest() {
+ return key_events_for_test;
+}
+
} // namespace ui

Powered by Google App Engine
This is Rietveld 408576698