chrome/browser/ui/input_method/input_method_engine_base.cc - Issue 2077783002: Make limitations for input.ime.sendKeyEvents API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/input_method/input_method_engine_base.cc

Issue 2077783002: Make limitations for input.ime.sendKeyEvents API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos error. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/input_method/input_method_engine_base.cc

diff --git a/chrome/browser/ui/input_method/input_method_engine_base.cc b/chrome/browser/ui/input_method/input_method_engine_base.cc

index 4ba4a75f300eba2fd7f7337fece0700e04d5f7d3..afc3fbda20e4f4f528c662eaca12bbf564350ec9 100644

--- a/chrome/browser/ui/input_method/input_method_engine_base.cc

+++ b/chrome/browser/ui/input_method/input_method_engine_base.cc

@@ -369,7 +369,9 @@ void InputMethodEngineBase::ProcessKeyEvent(const ui::KeyEvent& key_event,

if (&key_event == sent_key_event_)

ext_event.extension_id = extension_id_;

- observer_->OnKeyEvent(active_component_id_, ext_event, callback);

+ // Should not pass key event in password field.

+ if (current_input_type_ != ui::TEXT_INPUT_TYPE_PASSWORD)

+ observer_->OnKeyEvent(active_component_id_, ext_event, callback);

}

void InputMethodEngineBase::SetSurroundingText(const std::string& text,