Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

Issue 2077743005: [Mac][Material Design] Adjust (i) and lock Omnibox icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes for non-Retina. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
index 58028b62e4b7a2ebdb8a317dd24a0e813a3f8454..ad2d025e2bad333fc2a23bdd45b7e85c35aee1d1 100644
--- a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
@@ -60,6 +60,11 @@ EVBubbleDecoration::EVBubbleDecoration(LocationIconDecoration* location_icon)
if (!ui::MaterialDesignController::IsModeMaterial()) {
// Color tuples stolen from location_bar_view_gtk.cc.
SetTextColor(ColorWithRGBBytes(0x07, 0x95, 0x00));
+ } else {
tapted 2016/06/22 05:40:38 nit: now that there's an `else` the `if` condition
shrike 2016/06/22 21:44:50 Acknowledged.
+ // On Retina the text label is 1px above the Omnibox textfield's text
+ // baseline. If the Omnibox textfield also drew the label the baselines
+ // would align. This 1/2pt adjustment has no effect on non-Retina.
tapted 2016/06/22 05:40:38 I don't think the "no effect" comment is true. I s
shrike 2016/06/22 21:44:50 Thank you for double-checking.
+ SetBaselineOffset(0.5);
}
}

Powered by Google App Engine
This is Rietveld 408576698