Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3048)

Unified Diff: extensions/browser/api/web_request/web_request_event_router_delegate.h

Issue 2077723002: [Extensions] Short-circuit activity logging if not enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_event_router_delegate.h
diff --git a/extensions/browser/api/web_request/web_request_event_router_delegate.h b/extensions/browser/api/web_request/web_request_event_router_delegate.h
index fa23fb6b524ccdb82310e1d4c96b400b7f17a186..0ae3e08db6b2456fa7161285fca3572537e8cfc9 100644
--- a/extensions/browser/api/web_request/web_request_event_router_delegate.h
+++ b/extensions/browser/api/web_request/web_request_event_router_delegate.h
@@ -5,52 +5,20 @@
#ifndef EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_EVENT_ROUTER_DELEGATE_H_
#define EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_EVENT_ROUTER_DELEGATE_H_
-#include <memory>
#include <string>
-#include "base/macros.h"
-
-class GURL;
-
-namespace base {
-class DictionaryValue;
-} // namespace base
-
-namespace content {
-class BrowserContext;
-} // namespace content
-
-namespace net {
-class URLRequest;
-} // namespace net
-
namespace extensions {
-class WebRequestEventDetails;
-
// A delegate class of WebRequestApi that are not a part of chrome.
class WebRequestEventRouterDelegate {
public:
- WebRequestEventRouterDelegate();
- virtual ~WebRequestEventRouterDelegate();
-
- // Logs an extension action.
- virtual void LogExtensionActivity(
- content::BrowserContext* browser_context,
- bool is_incognito,
- const std::string& extension_id,
- const GURL& url,
- const std::string& api_call,
- std::unique_ptr<base::DictionaryValue> details) {}
+ virtual ~WebRequestEventRouterDelegate() {}
// Notifies that a webRequest event that normally would be forwarded to a
// listener was instead blocked because of withheld permissions.
virtual void NotifyWebRequestWithheld(int render_process_id,
int render_frame_id,
- const std::string& extension_id) {}
-
- private:
- DISALLOW_COPY_AND_ASSIGN(WebRequestEventRouterDelegate);
+ const std::string& extension_id) = 0;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698