Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3960)

Unified Diff: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

Issue 2077723002: [Extensions] Short-circuit activity logging if not enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
diff --git a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
index 4aa4c1f0d011f3695055ef83aa3bc754f00e1665..96f2a1c76d7a059a8c83f39e83f86718e307b814 100644
--- a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
+++ b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc
@@ -4,15 +4,11 @@
#include "chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h"
-#include "chrome/browser/extensions/activity_log/activity_action_constants.h"
-#include "chrome/browser/extensions/activity_log/activity_log.h"
#include "chrome/browser/extensions/extension_action_runner.h"
+#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
-#include "extensions/browser/api/activity_log/web_request_constants.h"
-#include "extensions/browser/api/web_request/web_request_event_details.h"
#include "extensions/browser/extension_registry.h"
-#include "net/url_request/url_request.h"
namespace {
@@ -55,31 +51,6 @@ ChromeExtensionWebRequestEventRouterDelegate::
~ChromeExtensionWebRequestEventRouterDelegate() {
}
-void ChromeExtensionWebRequestEventRouterDelegate::LogExtensionActivity(
- content::BrowserContext* browser_context,
- bool is_incognito,
- const std::string& extension_id,
- const GURL& url,
- const std::string& api_call,
- std::unique_ptr<base::DictionaryValue> details) {
- DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- if (!extensions::ExtensionsBrowserClient::Get()->IsValidContext(
- browser_context)) {
- return;
- }
-
- scoped_refptr<extensions::Action> action =
- new extensions::Action(extension_id,
- base::Time::Now(),
- extensions::Action::ACTION_WEB_REQUEST,
- api_call);
- action->set_page_url(url);
- action->set_page_incognito(is_incognito);
- action->mutable_other()->Set(activity_log_constants::kActionWebRequest,
- details.release());
- extensions::ActivityLog::GetInstance(browser_context)->LogAction(action);
-}
-
void ChromeExtensionWebRequestEventRouterDelegate::NotifyWebRequestWithheld(
int render_process_id,
int render_frame_id,

Powered by Google App Engine
This is Rietveld 408576698