[Extensions] Short-circuit activity logging if not enabled

chrome/browser/extensions/activity_log/activity_log_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/activity_log.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 12 matching lines @@
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/dom_action_types.h"
 #include "extensions/common/extension_builder.h"
+#include "extensions/common/test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #endif
 
 namespace {
 
@@ skipping 11 matching lines @@
     "HTMLQuoteElement.cite",        "HTMLScriptElement.src",
     "HTMLSourceElement.src",        "HTMLTrackElement.src",
     "HTMLVideoElement.poster"};
 
 }  // namespace
 
 namespace extensions {
 
 class ActivityLogTest : public ChromeRenderViewHostTestHarness {
  protected:
+  virtual bool enable_activity_logging_switch() const { return true; }
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
 #if defined OS_CHROMEOS
     test_user_manager_.reset(new chromeos::ScopedTestUserManager());
 #endif
     base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
-    base::CommandLine::ForCurrentProcess()->AppendSwitch(
-        switches::kEnableExtensionActivityLogging);
+    if (enable_activity_logging_switch()) {
+      base::CommandLine::ForCurrentProcess()->AppendSwitch(
+          switches::kEnableExtensionActivityLogging);
+    }
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kEnableExtensionActivityLogTesting);
     extension_service_ = static_cast<TestExtensionSystem*>(
         ExtensionSystem::Get(profile()))->CreateExtensionService
             (&command_line, base::FilePath(), false);
     base::RunLoop().RunUntilIdle();
   }
 
   void TearDown() override {
 #if defined OS_CHROMEOS
@@ skipping 157 matching lines @@
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
           .SetManifest(DictionaryBuilder()
                            .Set("name", "Test extension")
                            .Set("version", "1.0.0")
                            .Set("manifest_version", 2)
                            .Build())
           .Build();
   extension_service_->AddExtension(extension.get());
   ActivityLog* activity_log = ActivityLog::GetInstance(profile());
+  EXPECT_TRUE(activity_log->ShouldLog(extension->id()));
   ASSERT_TRUE(GetDatabaseEnabled());
   GURL url("http://www.google.com");
 
   prerender::PrerenderManager* prerender_manager =
       prerender::PrerenderManagerFactory::GetForProfile(
           Profile::FromBrowserContext(profile()));
 
   const gfx::Size kSize(640, 480);
   std::unique_ptr<prerender::PrerenderHandle> prerender_handle(
       prerender_manager->AddPrerenderFromOmnibox(
@@ skipping 26 matching lines @@
 }
 
 TEST_F(ActivityLogTest, ArgUrlExtraction) {
   ActivityLog* activity_log = ActivityLog::GetInstance(profile());
   std::unique_ptr<base::ListValue> args(new base::ListValue());
 
   base::Time now = base::Time::Now();
 
   // Submit a DOM API call which should have its URL extracted into the arg_url
   // field.
+  EXPECT_TRUE(activity_log->ShouldLog(kExtensionId));
   scoped_refptr<Action> action = new Action(kExtensionId,
                                             now,
                                             Action::ACTION_DOM_ACCESS,
                                             "XMLHttpRequest.open");
   action->set_page_url(GURL("http://www.google.com/"));
   action->mutable_args()->AppendString("POST");
   action->mutable_args()->AppendString("http://api.google.com/");
   action->mutable_other()->SetInteger(activity_log_constants::kActionDomVerb,
                                       DomActionType::METHOD);
   activity_log->LogAction(action);
@@ skipping 104 matching lines @@
   activity_log->GetFilteredActions(
       kExtensionId,
       Action::ACTION_ANY,
       "",
       "",
       "",
       -1,
       base::Bind(ActivityLogTest::RetrieveActions_ArgUrlApiCalls));
 }
 
+class ActivityLogTestWithoutSwitch : public ActivityLogTest {
+ public:
+  ActivityLogTestWithoutSwitch() {}
+  ~ActivityLogTestWithoutSwitch() override {}
+  bool enable_activity_logging_switch() const override { return false; }
+};
+
+TEST_F(ActivityLogTestWithoutSwitch, TestShouldLog) {
+  ActivityLog* activity_log = ActivityLog::GetInstance(profile());
+  scoped_refptr<const Extension> empty_extension =
+      test_util::CreateEmptyExtension();
+  extension_service_->AddExtension(empty_extension.get());
+  // Since the command line switch for logging isn't enabled and there's no
+  // watchdog app active, the activity log shouldn't log anything.
+  EXPECT_FALSE(activity_log->ShouldLog(empty_extension->id()));
+  const char kWhitelistedExtensionId[] = "eplckmlabaanikjjcgnigddmagoglhmp";
+  scoped_refptr<const Extension> activity_log_extension =
+      test_util::CreateEmptyExtension(kWhitelistedExtensionId);
+  extension_service_->AddExtension(activity_log_extension.get());
+  // Loading a watchdog app means the activity log should log other extension
+  // activities...
+  EXPECT_TRUE(activity_log->ShouldLog(empty_extension->id()));
+  // ... but not those of the watchdog app.
+  EXPECT_FALSE(activity_log->ShouldLog(activity_log_extension->id()));
+  extension_service_->DisableExtension(activity_log_extension->id(),
+                                       Extension::DISABLE_USER_ACTION);
+  // Disabling the watchdog app means that we're back to never logging anything.
+  EXPECT_FALSE(activity_log->ShouldLog(empty_extension->id()));
+}
+
 }  // namespace extensions