A few more cleanups to the pepper code. Dispatch IPCs in the sockets implementations directly by ha…

A few more cleanups to the pepper code. Dispatch IPCs in the sockets implementations directly by having each object generate its own routing id. This allows us to remove the code to handle mapping in PepperHelperImpl. Also get rid of ResourceHelper since it was just a wrapper around other methods.

BUG=263054
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215678

[scottmg, 2013-08-01 02:45:02]

lgtm

https://codereview.chromium.org/20777009/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_helper_impl.cc (right):

https://codereview.chromium.org/20777009/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_helper_impl.cc:118: new
PepperBrowserConnection(render_view);
why allocated and leaked now instead of contained?

[jam, 2013-08-01 06:53:35]

https://codereview.chromium.org/20777009/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_helper_impl.cc (right):

https://codereview.chromium.org/20777009/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_helper_impl.cc:118: new
PepperBrowserConnection(render_view);
On 2013/08/01 02:45:02, scottmg wrote:
> why allocated and leaked now instead of contained?

this is a RenderViewObserver which deletes itself when a RenderView goes away.
this way it gets to filter IPCs on its own, and can Send, without going through
this class

[jam, 2013-08-01 21:54:09]

dmichael: please review src/ppapi
ygorshenin: please review all the files with tcp in their name

my goal is to keep trimming pepper_helper_impl.cc until i can remove it
altogether

[dmichael (off chromium), 2013-08-01 22:43:01]

Could you make your first line of your commit message a short summary (maybe <=
80 chars)? And s/ResourceTracker/ResourceHelper in the commit message.

lgtm

https://codereview.chromium.org/20777009/diff/28001/content/renderer/render_t...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/20777009/diff/28001/content/renderer/render_t...
content/renderer/render_thread_impl.cc:1285: AsyncOpenFileCallback* callback =
nit: scoped_ptr?

https://codereview.chromium.org/20777009/diff/28001/ppapi/proxy/ppb_tcp_serve...
File ppapi/proxy/ppb_tcp_server_socket_private_proxy.cc (right):

https://codereview.chromium.org/20777009/diff/28001/ppapi/proxy/ppb_tcp_serve...
ppapi/proxy/ppb_tcp_server_socket_private_proxy.cc:188: TCPServerSocket* socket
= static_cast<TCPServerSocket*>(it->second);
suggestion: You could DCHECK(PpapiGlobals::Get()->IsHostGlobals()); to make sure
this cast is safe.

[jam, 2013-08-05 17:31:31]

after merging ygorshenin's change, no more changes are needed in src/ppapi

ygorshenin1-> moving you to cc