Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: base/memory/weak_ptr.h

Issue 20777008: Remove obsolete WeakPtr hack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/weak_ptr_unittest.cc » ('j') | base/memory/weak_ptr_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/weak_ptr.h
diff --git a/base/memory/weak_ptr.h b/base/memory/weak_ptr.h
index b4120a1140d109ff89f60e71a55e031e128220c9..1675889e22963ef23ff8812fda9d2b7e26db1192 100644
--- a/base/memory/weak_ptr.h
+++ b/base/memory/weak_ptr.h
@@ -90,9 +90,6 @@ class BASE_EXPORT WeakReference {
void Invalidate();
bool IsValid() const;
- // Remove this when crbug.com/234964 is addressed.
- void DetachFromThreadHack() { sequence_checker_.DetachFromSequence(); }
-
private:
friend class base::RefCountedThreadSafe<Flag>;
@@ -125,12 +122,6 @@ class BASE_EXPORT WeakReferenceOwner {
void Invalidate();
- // Remove this when crbug.com/234964 is addressed.
- void DetachFromThreadHack() {
- if (flag_.get())
- flag_->DetachFromThreadHack();
- }
-
private:
mutable scoped_refptr<WeakReference::Flag> flag_;
};
@@ -311,14 +302,6 @@ class SupportsWeakPtr : public internal::SupportsWeakPtrBase {
return WeakPtr<T>(weak_reference_owner_.GetRef(), static_cast<T*>(this));
}
- // Removes the binding, if any, from this object to a particular thread.
- // This is used in WebGraphicsContext3DInProcessCommandBufferImpl to work-
- // around access to cmmand buffer objects by more than one thread.
- // Remove this when crbug.com/234964 is addressed.
- void DetachFromThreadHack() {
- weak_reference_owner_.DetachFromThreadHack();
- }
-
protected:
~SupportsWeakPtr() {}
« no previous file with comments | « no previous file | base/memory/weak_ptr_unittest.cc » ('j') | base/memory/weak_ptr_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698