Don't rely on untrusted events in site isolation browser test.

Don't rely on untrusted events in site isolation browser test.

The site isolation browser test for two iframes showing selects
simultaneously relies on untrusted events performing the default
action.

Since untrusted event dispatching will be removed from blink soon
fix this test.

BUG=520519
Committed: https://crrev.com/e0f8ed74386ec1f3a3a54d764f24256808a10827
Cr-Commit-Position: refs/heads/master@{#400397}

[dtapuska, 2016-06-16 22:17:01]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2016-06-16 22:35:23]

creis@chromium.org changed reviewers:
+ alexmos@chromium.org

[Charlie Reis, 2016-06-16 22:35:23]

creis@chromium.org changed required reviewers:
+ alexmos@chromium.org

[Charlie Reis, 2016-06-16 22:35:23]

Alex, can you confirm this is ok, since you added the test in
https://codereview.chromium.org/1986643002?  Otherwise LGTM with a comment
request.

https://codereview.chromium.org/2077683003/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2077683003/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7072: event.text[0] = ' ';
This isn't entirely clear to me at first glance.  I suppose hitting space when a
select menu is focused opens it?  Maybe you can update the comment below (saying
that and explaining the bit about untrusted events), and then put this event
declaration below the comment?

[dtapuska, 2016-06-16 23:05:44]

On 2016/06/16 22:35:23, Charlie Reis (OOO til June 18) wrote:
> Alex, can you confirm this is ok, since you added the test in
> https://codereview.chromium.org/1986643002  Otherwise LGTM with a comment
> request.
> 
>
https://codereview.chromium.org/2077683003/diff/1/content/browser/site_per_pr...
> File content/browser/site_per_process_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2077683003/diff/1/content/browser/site_per_pr...
> content/browser/site_per_process_browsertest.cc:7072: event.text[0] = ' ';
> This isn't entirely clear to me at first glance.  I suppose hitting space when
a
> select menu is focused opens it?  Maybe you can update the comment below
(saying
> that and explaining the bit about untrusted events), and then put this event
> declaration below the comment?

I've adjusted the comment; hopefully it is clearer now what the code is doing.

[alexmos, 2016-06-17 07:00:07]

LGTM

[dtapuska, 2016-06-17 07:05:23]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-06-17 07:05:23]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2077683003/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-06-17 07:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077683003/20001

[commit-bot: I haz the power, 2016-06-17 08:23:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 08:25:11]

Description was changed from

==========
Don't rely on untrusted events in site isolation browser test.

The site isolation browser test for two iframes showing selects
simultaneously relies on untrusted events performing the default
action.

Since untrusted event dispatching will be removed from blink soon
fix this test.

BUG=520519
==========

to

==========
Don't rely on untrusted events in site isolation browser test.

The site isolation browser test for two iframes showing selects
simultaneously relies on untrusted events performing the default
action.

Since untrusted event dispatching will be removed from blink soon
fix this test.

BUG=520519

Committed: https://crrev.com/e0f8ed74386ec1f3a3a54d764f24256808a10827
Cr-Commit-Position: refs/heads/master@{#400397}
==========

[commit-bot: I haz the power, 2016-06-17 08:25:12]

Patchset 2 (id:??) landed as
https://crrev.com/e0f8ed74386ec1f3a3a54d764f24256808a10827
Cr-Commit-Position: refs/heads/master@{#400397}