Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2077663002: Reduce redundant code in PaymentRequest::OnPaymentComplete(). (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
Reviewers:
palmer
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce redundant code in PaymentRequest::OnPaymentComplete(). BUG=617195 Committed: https://crrev.com/b2a570d184fac21f7299905ee6eaaea371f857b3 Cr-Commit-Position: refs/heads/master@{#400352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +4 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
please use gerrit instead
palmer@: ptal. This is the follow up you've requested.
4 years, 6 months ago (2016-06-16 21:53:33 UTC) #2
palmer
lgtm
4 years, 6 months ago (2016-06-16 22:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077663002/1
4 years, 6 months ago (2016-06-16 22:13:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/240508)
4 years, 6 months ago (2016-06-17 01:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077663002/1
4 years, 6 months ago (2016-06-17 02:51:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 04:20:45 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 04:22:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2a570d184fac21f7299905ee6eaaea371f857b3
Cr-Commit-Position: refs/heads/master@{#400352}

Powered by Google App Engine
This is Rietveld 408576698