Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2077653002: Revert IPC SyncChannel to base::WaitableEvent waiting (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert IPC SyncChannel to base::WaitableEvent waiting The new Mojo sync waiting behavior is causing some shutdown hangs on Mac and test flake on Windows. Reverting for now until that's sorted out. Note that this behavior was landed as part of a larger change which does not need to be reverted entirely, hence this partial revert. BUG=620866, 620683 TBR=jam@chromium.org since it's just a revert Committed: https://crrev.com/7b7e60fe742530a34e7480307ae4d58d2f61eafa Cr-Commit-Position: refs/heads/master@{#400287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -276 lines) Patch
M ipc/ipc_sync_channel.h View 7 chunks +15 lines, -18 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 17 chunks +85 lines, -177 lines 0 comments Download
M ipc/ipc_sync_message.h View 4 chunks +25 lines, -12 lines 0 comments Download
M ipc/ipc_sync_message.cc View 3 chunks +22 lines, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 3 chunks +3 lines, -15 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 6 chunks +11 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077653002/1
4 years, 6 months ago (2016-06-16 21:43:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 23:15:34 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 23:18:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b7e60fe742530a34e7480307ae4d58d2f61eafa
Cr-Commit-Position: refs/heads/master@{#400287}

Powered by Google App Engine
This is Rietveld 408576698