Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2077623002: [wasm] memory size is an uint32_t, not a size_t. (Closed)

Created:
4 years, 6 months ago by Mircea Trofin
Modified:
4 years, 6 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] memory size is an uint32_t, not a size_t. BUG= Committed: https://crrev.com/273bb58c33dc325b24e243b1040747e8e94f9dd2 Cr-Commit-Position: refs/heads/master@{#37044}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 34 chunks +52 lines, -52 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mircea Trofin
4 years, 6 months ago (2016-06-16 21:08:28 UTC) #3
bradnelson
lgtm https://codereview.chromium.org/2077623002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/2077623002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode1627 test/cctest/wasm/test-run-wasm.cc:1627: for (size_t i = 0; i < size; ...
4 years, 6 months ago (2016-06-16 21:11:23 UTC) #4
Mircea Trofin
https://codereview.chromium.org/2077623002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/2077623002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode1627 test/cctest/wasm/test-run-wasm.cc:1627: for (size_t i = 0; i < size; i++) ...
4 years, 6 months ago (2016-06-16 21:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077623002/20001
4 years, 6 months ago (2016-06-16 22:19:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 22:21:40 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 22:23:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/273bb58c33dc325b24e243b1040747e8e94f9dd2
Cr-Commit-Position: refs/heads/master@{#37044}

Powered by Google App Engine
This is Rietveld 408576698