Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: base/message_loop/message_pump_win.h

Issue 2077613002: Verify if GPU message pump is signaled when it hangs in WaitForWork (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed spelling Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/message_loop/message_pump_win.h
diff --git a/base/message_loop/message_pump_win.h b/base/message_loop/message_pump_win.h
index bf4cdaa8420b8ba3c6f2b9c81f5679a490c71138..84ee3cb561875f022109d3ee2c02e709e1e039ad 100644
--- a/base/message_loop/message_pump_win.h
+++ b/base/message_loop/message_pump_win.h
@@ -164,6 +164,13 @@ class BASE_EXPORT MessagePumpForGpu : public MessagePumpWin {
void ScheduleWork() override;
void ScheduleDelayedWork(const TimeTicks& delayed_work_time) override;
+ // TODO (stanisc): crbug.com/596190: Remove this after the signaling issue
+ // has been investigated.
+ // This should be used for diagnostic only. If message pump wake-up mechanism
+ // is based on auto-reset event this call would reset the event to unset
+ // state.
+ bool WasSignaled() override;
+
private:
// MessagePumpWin methods:
void DoRunLoop() override;

Powered by Google App Engine
This is Rietveld 408576698