Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2077593002: milo: fix pending build test (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

milo: fix pending build test It was incorrectly marked as running R=hinoka@chromium.org, estaab@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/72a5d319b73f803c36262fad20154c5dbd32bb71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M appengine/cmd/milo/swarming/expectations/build-pending.json View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/testdata/build-pending.swarm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077593002/1
4 years, 6 months ago (2016-06-16 19:30:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 19:42:11 UTC) #4
nodir
PTAL
4 years, 6 months ago (2016-06-16 21:09:28 UTC) #5
hinoka
lgtm
4 years, 6 months ago (2016-06-16 21:12:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077593002/1
4 years, 6 months ago (2016-06-16 21:30:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 21:33:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/72a5d319b73f803c36262fad20154c5dbd32bb71

Powered by Google App Engine
This is Rietveld 408576698