Make SDK summary writing available to analyzer clients.

Make SDK summary writing available to analyzer clients.

Not API (in `lib/src`) but available nonethess to clients such as flutter who need to be able to write their own SDK summaries (and ideally not duplicate low-level flat_buffer interactions).

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/772972ad3235208af8d20286474c92c983b8336b

[pquitslund, 2016-06-16 19:17:44]

Description was changed from

==========
SDK summary generation for all.

Not API (in `lib/src`) but available nonethess to clients such as flutter who
need to be able to write their own SDK summaries (and ideally not duplicate
low-level flat_buffer interactions).

BUG=
==========

to

==========
Make SDK summary writing available to analyzer clients.

Not API (in `lib/src`) but available nonethess to clients such as flutter who
need to be able to write their own SDK summaries (and ideally not duplicate
low-level flat_buffer interactions).

BUG=
==========

[pquitslund, 2016-06-16 19:18:02]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Brian Wilkerson, 2016-06-16 19:43:55]

lgtm

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_file_builder.dart (right):

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:85: class SummaryOutput {
Comment?

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:149: File
write(SummaryOutput output, String outputPath) {
Not sure what value there is in creating a private class with a single method
when that class is used in only one place. Consider moving the body of this
method into SummaryOutput.write.

[pquitslund, 2016-06-16 20:52:16]

Thanks!

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summary_file_builder.dart (right):

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:85: class SummaryOutput {
On 2016/06/16 19:43:55, Brian Wilkerson wrote:
> Comment?

Done.

https://codereview.chromium.org/2077583002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summary_file_builder.dart:149: File
write(SummaryOutput output, String outputPath) {
On 2016/06/16 19:43:55, Brian Wilkerson wrote:
> Not sure what value there is in creating a private class with a single method
> when that class is used in only one place. Consider moving the body of this
> method into SummaryOutput.write.

Done.

[Paul Berry, 2016-06-16 20:59:54]

lgtm

[pquitslund, 2016-06-16 22:09:46]

Description was changed from

==========
Make SDK summary writing available to analyzer clients.

Not API (in `lib/src`) but available nonethess to clients such as flutter who
need to be able to write their own SDK summaries (and ideally not duplicate
low-level flat_buffer interactions).

BUG=
==========

to

==========
Make SDK summary writing available to analyzer clients.

Not API (in `lib/src`) but available nonethess to clients such as flutter who
need to be able to write their own SDK summaries (and ideally not duplicate
low-level flat_buffer interactions).

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/772972ad3235208af8d20286474c92c983b8336b
==========

[pquitslund, 2016-06-16 22:09:48]

Committed patchset #2 (id:20001) manually as
772972ad3235208af8d20286474c92c983b8336b (presubmit successful).