base: Use compiler builtins for byte swapping

base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*

Committed: https://crrev.com/1a09b177d4641f50d96c82218c0fd0155d27ae4f
Cr-Commit-Position: refs/heads/master@{#400540}

[robert.bradford, 2016-06-16 16:59:20]

Description was changed from

==========
base: Use compiler builtins for byteswaps

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=None
TEST=All tests on trybots pass
==========

to

==========
base: Use compiler builtins for byteswaps

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=All tests on trybots pass
==========

[robert.bradford, 2016-06-16 17:00:21]

Description was changed from

==========
base: Use compiler builtins for byteswaps

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=All tests on trybots pass
==========

to

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=All tests on trybots pass
==========

[robert.bradford, 2016-06-16 18:00:02]

robert.bradford@intel.com changed reviewers:
+ danakj@chromium.org

[robert.bradford, 2016-06-16 18:00:03]

danakj@ Could you review this change in base/ ?

[danakj, 2016-06-16 18:05:21]

Would you mind adding a unit test for these methods?

[robert.bradford, 2016-06-17 11:14:58]

On 2016/06/16 18:05:21, danakj wrote:
> Would you mind adding a unit test for these methods?

Done! Please re-review.

[danakj, 2016-06-17 18:10:23]

Thanks :)

There's a compiler problem on windows:

e:\b\build\slave\win\build\src\base\sys_byteorder.h(23): error C3861:
'_byteswap_ushort': identifier not found
e:\b\build\slave\win\build\src\base\sys_byteorder.h(31): error C3861:
'_byteswap_ulong': identifier not found
e:\b\build\slave\win\build\src\base\sys_byteorder.h(39): error C3861:
'_byteswap_uint64': identifier not found

Do you need #include <stdlib.h> on windows?

[robert.bradford, 2016-06-17 21:57:38]

Patchset #3 (id:40001) has been deleted

[robert.bradford, 2016-06-17 22:00:12]

Description was changed from

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=All tests on trybots pass
==========

to

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*
==========

[robert.bradford, 2016-06-17 22:02:06]

On 2016/06/17 18:10:23, danakj wrote:

> Do you need #include <stdlib.h> on windows?

Fixed. I copied what Blink had and made it conditional on MSVC.

[danakj, 2016-06-17 22:06:10]

LGTM bots willing

[robert.bradford, 2016-06-17 22:18:59]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2016-06-17 22:19:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077563002/60001

[commit-bot: I haz the power, 2016-06-17 23:26:23]

Description was changed from

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*
==========

to

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*
==========

[commit-bot: I haz the power, 2016-06-17 23:26:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-17 23:29:24]

Description was changed from

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*
==========

to

==========
base: Use compiler builtins for byte swapping

Blink/WTF already makes use of compiler builtins for endian byte
swapping so do the same in Chromium base itself.

BUG=620779
TEST=base_unittests:ByteOrderTest.*

Committed: https://crrev.com/1a09b177d4641f50d96c82218c0fd0155d27ae4f
Cr-Commit-Position: refs/heads/master@{#400540}
==========

[commit-bot: I haz the power, 2016-06-17 23:29:25]

Patchset 3 (id:??) landed as
https://crrev.com/1a09b177d4641f50d96c82218c0fd0155d27ae4f
Cr-Commit-Position: refs/heads/master@{#400540}