Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.idl

Issue 2077523002: Add contentWindow attribute for <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html ('K') | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLObjectElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.idl b/third_party/WebKit/Source/core/html/HTMLObjectElement.idl
index 77d1cf9e1d15ada3bcadc80fb7f728b47857b721..a5c644d189633be0b62a2342c0c1eaf2b1f21ba1 100644
--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.idl
@@ -34,7 +34,7 @@
[CEReactions, Reflect] attribute DOMString width;
[CEReactions, Reflect] attribute DOMString height;
[CheckSecurity=ReturnValue] readonly attribute Document? contentDocument;
- // TODO(foolip): readonly attribute WindowProxy? contentWindow;
fs 2016/06/22 08:33:02 Maybe keep the/a TODO because of the WindowProxy<-
Shanmuga Pandi 2016/06/22 10:27:32 Done.
+ readonly attribute Window? contentWindow;
[CheckSecurity=ReturnValue, RaisesException] Document? getSVGDocument();
readonly attribute boolean willValidate;
« third_party/WebKit/LayoutTests/svg/as-object/svg-object-contentWindow-query.html ('K') | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698