third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg - Issue 2077523002: Add contentWindow attribute for <object> elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/as-object/resources/svg-object-contentWindow.svg

Issue 2077523002: Add contentWindow attribute for <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	fs 2016/06/22 08:33:02 Not needed. Not needed. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > Not needed. Done.
	2 <svg xmlns="http://www.w3.org/2000/svg" width="0" height="0">
	fs 2016/06/22 08:33:02 No need to specify empty dimensions. No need to specify empty dimensions. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > No need to specify empty dimensions. Done.
	3 <script type="text/javascript">
	fs 2016/06/22 08:33:02 Don't need to specify 'type'. Don't need to specify 'type'. Shanmuga Pandi 2016/06/22 10:27:32 Done. Show quoted text On 2016/06/22 08:33:02, fs wrote: > Don't need to specify 'type'. Done.
	4 window.attrInContentWindow = "validAttr";

	5 </script>

	6 </svg>

OLD	NEW