Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/md_history/history_list.js

Issue 2077483002: MD History: Add confirmation dialog when deleting items from the toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_refactor_dialog
Patch Set: Fix test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.js ('k') | chrome/browser/resources/md_history/list_container.html » ('j') | chrome/browser/resources/md_history/list_container.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/history_list.js
diff --git a/chrome/browser/resources/md_history/history_list.js b/chrome/browser/resources/md_history/history_list.js
index 68f626d159a7467eb5014116d5f6882ed250641d..55af60bb6b4a7f1615daecd99969042efb4e2e93 100644
--- a/chrome/browser/resources/md_history/history_list.js
+++ b/chrome/browser/resources/md_history/history_list.js
@@ -181,7 +181,9 @@ Polymer({
/**
* Performs a request to the backend to delete all selected items. If
- * successful, removes them from the view.
+ * successful, removes them from the view. Does not prompt the user before
+ * deleting -- see <history-list-container> for a version of this method which
+ * does prompt.
*/
deleteSelected: function() {
var toBeRemoved = this.historyData_.filter(function(item) {
« no previous file with comments | « chrome/browser/resources/md_history/app.js ('k') | chrome/browser/resources/md_history/list_container.html » ('j') | chrome/browser/resources/md_history/list_container.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698