chrome/browser/browser_resources.grd - Issue 2077473002: MD History: add sign in promo in synced tabs when user isn't logged in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_resources.grd

Issue 2077473002: MD History: add sign in promo in synced tabs when user isn't logged in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/md_history/app.js » ('j') | chrome/browser/resources/md_history/synced_device_manager.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_resources.grd

diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd

index e1fd4396f4018b3be3788fb63caf2a37132f2f0c..6aec02f2f4af76cc6948658ac0f9aae239529bf8 100644

--- a/chrome/browser/browser_resources.grd

+++ b/chrome/browser/browser_resources.grd

@@ -228,6 +228,8 @@

+ <include name="IDR_MD_HISTORY_IMAGES_100_NO_SYNCED_TAB_PNG" file="resources\md_history\images\100\sign_in_promo.png" type="BINDATA" />

tsergeant 2016/06/21 04:33:50 You should change the resource name to match the n

lshang 2016/06/21 05:39:59 Done. Also changed md_history_ui.cc correspondingl

+ <include name="IDR_MD_HISTORY_IMAGES_200_NO_SYNCED_TAB_PNG" file="resources\md_history\images\200\sign_in_promo.png" type="BINDATA" />