Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 1 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> | 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> |
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> | 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> |
| 5 <link rel="import" href="chrome://resources/html/cr/ui/position_util.html"> | 6 <link rel="import" href="chrome://resources/html/cr/ui/position_util.html"> |
| 6 <link rel="import" href="chrome://history/shared_style.html"> | 7 <link rel="import" href="chrome://history/shared_style.html"> |
| 7 <link rel="import" href="chrome://history/synced_device_card.html"> | 8 <link rel="import" href="chrome://history/synced_device_card.html"> |
| 8 | 9 |
| 9 <dom-module id="history-synced-device-manager"> | 10 <dom-module id="history-synced-device-manager"> |
| 10 <style include="shared-style"></style> | 11 <style include="shared-style"></style> |
| 11 <template> | 12 <template> |
| 12 <style> | 13 <style> |
| 13 :host { | 14 :host { |
| 14 overflow: auto; | 15 overflow: auto; |
| 15 padding-top: var(--first-card-padding-top); | 16 padding-top: var(--first-card-padding-top); |
|
tsergeant
2016/06/17 06:22:03
It would be a good idea to move this padding out o
lshang
2016/06/21 03:00:26
Done.
I moved padding out of :host and onto the wr
tsergeant
2016/06/21 04:33:50
Yup, sounds good to me
| |
| 17 position: relative; | |
| 16 } | 18 } |
| 19 | |
| 20 #illustration { | |
| 21 background: -webkit-image-set( | |
| 22 url(chrome://history/images/100/no_synced_tab.png) 1x, | |
| 23 url(chrome://history/images/200/no_synced_tab.png) 2x) | |
| 24 no-repeat center center; | |
| 25 height: 222px; | |
| 26 margin-top: 60px; | |
| 27 width: 594px; | |
| 28 } | |
| 29 | |
| 30 #no-synced-tabs { | |
| 31 bottom: 0; | |
|
tsergeant
2016/06/17 06:22:03
It shouldn't be necessary to use absolute position
lshang
2016/06/21 03:00:26
Done.
It works! With a single line, instead of wh
| |
| 32 left: 0; | |
| 33 margin: auto; | |
| 34 position: absolute; | |
| 35 right: 0; | |
| 36 top: 0; | |
| 37 } | |
| 38 | |
| 39 #sign-in-guide { | |
| 40 display: flex; | |
| 41 justify-content: center; | |
| 42 text-align: center; | |
| 43 } | |
| 44 | |
| 45 #sign-in-promo { | |
| 46 color: #333; | |
| 47 font-size: 28px; | |
| 48 margin-top: 40px; | |
| 49 } | |
| 50 | |
| 51 #sign-in-promo-desc { | |
| 52 color: #848484; | |
| 53 font-size: 16px; | |
| 54 margin-top: 10px; | |
| 55 } | |
| 56 | |
| 57 #sign-in-button { | |
| 58 background-color: var(--google-blue-500); | |
| 59 color: white; | |
| 60 font-size: 14px; | |
| 61 margin-top: 24px; | |
| 62 } | |
| 63 | |
| 17 </style> | 64 </style> |
| 18 <template is="dom-repeat" items="[[syncedDevices_]]" as="syncedDevice"> | 65 <template is="dom-repeat" items="[[syncedDevices_]]" as="syncedDevice"> |
| 19 <history-synced-device-card device="[[syncedDevice.device]]" | 66 <history-synced-device-card device="[[syncedDevice.device]]" |
| 20 last-update-time="[[syncedDevice.lastUpdateTime]]" | 67 last-update-time="[[syncedDevice.lastUpdateTime]]" |
| 21 tabs="[[syncedDevice.tabs]]" | 68 tabs="[[syncedDevice.tabs]]" |
| 22 separator-indexes="[[syncedDevice.separatorIndexes]]"> | 69 separator-indexes="[[syncedDevice.separatorIndexes]]"> |
| 23 </history-synced-device-card> | 70 </history-synced-device-card> |
| 24 </template> | 71 </template> |
| 72 <div id="no-synced-tabs" class="centered-message" | |
| 73 hidden="[[!showNoSyncedMessage_]]"> | |
| 74 <span><!-- Text populated dynamically. --></span> | |
| 75 </div> | |
| 76 <div id="sign-in-guide" hidden$="[[signInState_]]"> | |
| 77 <div> | |
|
tsergeant
2016/06/17 06:22:03
This div doesn't seem to be doing much.
You can g
lshang
2016/06/21 03:00:26
Done.
| |
| 78 <div id="illustration"></div> | |
| 79 <div id="sign-in-promo">$i18n{signInPromo}</div> | |
| 80 <div id="sign-in-promo-desc">$i18n{signInPromoDesc}</div> | |
| 81 <a> | |
|
tsergeant
2016/06/17 06:22:03
Similarly, this <a> isn't doing anything and can b
lshang
2016/06/21 03:00:26
Done.
| |
| 82 <paper-button id="sign-in-button" on-tap="onSignInTap_"> | |
| 83 $i18n{signInButton} | |
| 84 </paper-button> | |
| 85 </a> | |
| 86 </div> | |
| 87 </div> | |
| 88 | |
| 25 </template> | 89 </template> |
| 26 <script src="chrome://history/synced_device_manager.js"></script> | 90 <script src="chrome://history/synced_device_manager.js"></script> |
| 27 </dom-module> | 91 </dom-module> |
| OLD | NEW |