Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2077443002: Switch webgl2_conformance_tests to new harness, and shard them. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch webgl2_conformance_tests to new harness, and shard them. BUG=352807 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/48321ca0bcdb5af989517d61e2f927501271faa0 Cr-Commit-Position: refs/heads/master@{#401531}

Patch Set 1 #

Patch Set 2 : Remove obsolete manage.py exceptions. #

Patch Set 3 : Added telemetry_gpu_integration_test_run GYP target. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fix bug in harness. Mark flaky test. Add Ned and me as per-file OWNERS. #

Total comments: 7

Patch Set 6 : Re-fetch current tab after browser restart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -92 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 7 chunks +41 lines, -14 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 46 chunks +92 lines, -69 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 1 chunk +3 lines, -8 lines 0 comments Download
M testing/scripts/OWNERS View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M testing/scripts/run_gpu_integration_test_as_googletest.py View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 30 (12 generated)
Ken Russell (switch to Gerrit)
Mo, Dirk: please review. Thanks.
4 years, 6 months ago (2016-06-16 01:10:07 UTC) #3
Zhenyao Mo
lgtm This is awesome
4 years, 6 months ago (2016-06-16 02:54:02 UTC) #4
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-16 18:41:04 UTC) #5
Ken Russell (switch to Gerrit)
It turns out there is a problem in the recipe code which is preventing these ...
4 years, 6 months ago (2016-06-16 20:01:47 UTC) #6
Ken Russell (switch to Gerrit)
The sharding is working. The shards aren't well balanced yet. This needs to be fixed ...
4 years, 6 months ago (2016-06-17 02:57:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077443002/40001
4 years, 6 months ago (2016-06-17 02:57:40 UTC) #10
Ken Russell (switch to Gerrit)
On 2016/06/17 02:57:40, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-06-17 04:03:51 UTC) #12
Ken Russell (switch to Gerrit)
Dirk, could Ned and I be per-file OWNERS of the Telemetry based scripts in src/testing/scripts?
4 years, 6 months ago (2016-06-22 22:16:54 UTC) #13
Dirk Pranke
lgtm w/ nits (including OWNERS change). https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py#newcode1125 content/test/gpu/generate_buildbot_json.py:1125: else 'telemetry_gpu_test'), nit: ...
4 years, 6 months ago (2016-06-22 22:33:32 UTC) #14
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py#newcode1125 content/test/gpu/generate_buildbot_json.py:1125: else 'telemetry_gpu_test'), On 2016/06/22 22:33:32, Dirk Pranke wrote: > ...
4 years, 6 months ago (2016-06-22 23:01:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077443002/80001
4 years, 6 months ago (2016-06-22 23:02:24 UTC) #18
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2077443002/diff/80001/content/test/gpu/generate_buildbot_json.py#newcode1125 content/test/gpu/generate_buildbot_json.py:1125: else 'telemetry_gpu_test'), On 2016/06/22 23:01:04, Ken Russell wrote: > ...
4 years, 6 months ago (2016-06-22 23:20:55 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1728)
4 years, 6 months ago (2016-06-23 00:00:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077443002/100001
4 years, 6 months ago (2016-06-23 01:24:03 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-23 03:24:26 UTC) #25
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/48321ca0bcdb5af989517d61e2f927501271faa0 Cr-Commit-Position: refs/heads/master@{#401531}
4 years, 6 months ago (2016-06-23 03:27:37 UTC) #27
qiankun
Hi Ken, I found sharding didn't work sometimes. Do you know is it expected or ...
4 years, 6 months ago (2016-06-23 14:04:10 UTC) #29
Ken Russell (switch to Gerrit)
4 years, 6 months ago (2016-06-23 17:59:41 UTC) #30
Message was sent while issue was closed.
On 2016/06/23 14:04:10, qiankun wrote:
> Hi Ken,
> I found sharding didn't work sometimes. Do you know is it expected or a bug?
> Please take a look at the log:
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu....

Hi Qiankun,

Thanks for pointing this out. There was a problem with the updates to
chromium.gpu.fyi.json, being fixed in
https://codereview.chromium.org/2090143003/ .

Powered by Google App Engine
This is Rietveld 408576698