Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 207743002: Mark MediaQueryData as stack allocated. (Closed)

Created:
6 years, 9 months ago by zerny-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, oilpan-reviews
Visibility:
Public.

Description

Mark MediaQueryData as stack allocated. Its only use is as a part object of the stack-allocated MediaQueryParser. R=ager@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/parser/MediaQueryParser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
zerny-chromium
6 years, 9 months ago (2014-03-21 07:17:57 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-21 07:18:34 UTC) #2
zerny-chromium
Owner: haraken
6 years, 9 months ago (2014-03-21 07:19:29 UTC) #3
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-21 07:20:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/207743002/1
6 years, 9 months ago (2014-03-21 07:20:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 07:23:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 07:23:18 UTC) #7
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-21 07:31:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/207743002/1
6 years, 9 months ago (2014-03-21 07:31:59 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 07:32:25 UTC) #10
Message was sent while issue was closed.
Change committed as 169725

Powered by Google App Engine
This is Rietveld 408576698