Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

Issue 2077413005: Add "alpha" option to PaintWorklet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
index 1f33dae2b993faefe2992108a8c4627844348b23..309c83d4f7c6306d978efb1be1ca9cf9f9231036 100644
--- a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
@@ -89,6 +89,16 @@ void PaintWorkletGlobalScope::registerPaint(const String& name, const ScriptValu
}
}
+ // Parse 'alpha' AKA hasAlphaChannel property.
+ v8::Local<v8::Value> alphaValue;
+ if (!v8Call(constructor->Get(context, v8String(isolate, "alpha")), alphaValue))
+ return;
+ if (!isUndefinedOrNull(alphaValue) && !alphaValue->IsBoolean()) {
+ exceptionState.throwTypeError("The 'alpha' property on the class is not a boolean.");
+ return;
+ }
+ bool hasAlphaChannel = v8::Local<v8::Boolean>::Cast(alphaValue)->Value();
+
v8::Local<v8::Value> prototypeValue;
if (!v8Call(constructor->Get(context, v8String(isolate, "prototype")), prototypeValue))
return;
@@ -121,7 +131,7 @@ void PaintWorkletGlobalScope::registerPaint(const String& name, const ScriptValu
v8::Local<v8::Function> paint = v8::Local<v8::Function>::Cast(paintValue);
- CSSPaintDefinition* definition = CSSPaintDefinition::create(scriptController()->getScriptState(), constructor, paint, nativeInvalidationProperties, customInvalidationProperties);
+ CSSPaintDefinition* definition = CSSPaintDefinition::create(scriptController()->getScriptState(), constructor, paint, nativeInvalidationProperties, customInvalidationProperties, hasAlphaChannel);
m_paintDefinitions.set(name, definition);
// Set the definition on any pending generators.

Powered by Google App Engine
This is Rietveld 408576698