Convert video-duration*, video-error* and video-load* tests to testharness.js

Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/cbfa87316823945f92843462c7643e7720d8f623
Cr-Commit-Position: refs/heads/master@{#400908}

[Srirama, 2016-06-20 13:45:56]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js.

Cleaning up video-duration*, video-error* and video-load* tests
in media to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-20 13:46:36]

Description was changed from

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js.

Cleaning up video-duration*, video-error* and video-load* tests
in media to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-20 13:47:52]

Description was changed from

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-20 13:55:00]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-06-20 13:56:38]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-20 13:56:39]

PTAL

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-load-preload-none.html (right):

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-load-preload-none.html:21: }, 500);
Intentionally changed it to give enough time to fire "loadedmetadata". I just
verified by removing "preload:none".

[fs, 2016-06-20 14:32:25]

LGTM w/ irk

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-error-does-not-exist.html
(left):

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-error-does-not-exist.html:11:
waitForEventAndTest("canplaythrough", "false");
(I wonder if this was intended as an "unreachable" type check?)

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-load-preload-none.html (right):

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-load-preload-none.html:21: }, 500);
On 2016/06/20 at 13:56:39, Srirama wrote:
> Intentionally changed it to give enough time to fire "loadedmetadata". I just
verified by removing "preload:none".

Hmm, this means the test will take twice as long to run, which is a bit iffy
since that adds up on the bots. It's difficult for something not happening
though... (especially with the additional uncertainty we have here...)

[Srirama, 2016-06-21 05:07:40]

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-error-does-not-exist.html
(left):

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-error-does-not-exist.html:11:
waitForEventAndTest("canplaythrough", "false");
On 2016/06/20 14:32:25, fs wrote:
> (I wonder if this was intended as an "unreachable" type check?)

Done.

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-load-preload-none.html (right):

https://codereview.chromium.org/2077413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-load-preload-none.html:21: }, 500);
On 2016/06/20 14:32:25, fs wrote:
> On 2016/06/20 at 13:56:39, Srirama wrote:
> > Intentionally changed it to give enough time to fire "loadedmetadata". I
just
> verified by removing "preload:none".
> 
> Hmm, this means the test will take twice as long to run, which is a bit iffy
> since that adds up on the bots. It's difficult for something not happening
> though... (especially with the additional uncertainty we have here...)

ok, tuned it to 300.

[Srirama, 2016-06-21 05:08:10]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-21 05:08:10]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2077413002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-21 05:09:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077413002/40001

[commit-bot: I haz the power, 2016-06-21 06:23:45]

Description was changed from

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-21 06:23:46]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-21 06:25:12]

Description was changed from

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-duration*, video-error* and video-load* tests to testharness.js

Cleaning up video-duration*, video-error* and video-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/cbfa87316823945f92843462c7643e7720d8f623
Cr-Commit-Position: refs/heads/master@{#400908}
==========

[commit-bot: I haz the power, 2016-06-21 06:25:14]

Patchset 2 (id:??) landed as
https://crrev.com/cbfa87316823945f92843462c7643e7720d8f623
Cr-Commit-Position: refs/heads/master@{#400908}