First cut at the component observer.

Adding a per-component observer to get events from the component updater service.

Once pNacl migrates to the new API, the old style notifications will be removed.

More events will be added in the future iterations.


BUG=245318
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215131

[cpu_(ooo_6.6-7.5), 2013-07-27 02:10:37]

looks good

[waffles, 2013-07-31 01:31:30]

lgtm

(w/ two comment nitpicks.)

We've discussed this in person, but more largely, I wonder what the value of the
`int extra` is; I believe you said it probably wasn't going to survive long,
which is fine with me. 

I hope that the three of us we can reach consensus on what data to expose
through this interface.

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
chrome/browser/component_updater/component_updater_service.h:64: // the
notification is send the component will be downloaded.
send -> sent

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
chrome/browser/component_updater/component_updater_service.h:67: // Send when
the new component has been downloaded and an installation
Send -> Sent

[Sorin Jianu, 2013-07-31 01:38:58]

Thanks Josh. Patchset uploaded.

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
chrome/browser/component_updater/component_updater_service.h:64: // the
notification is send the component will be downloaded.
On 2013/07/31 01:31:30, waffles wrote:
> send -> sent

Done.

https://codereview.chromium.org/20774003/diff/9002/chrome/browser/component_u...
chrome/browser/component_updater/component_updater_service.h:67: // Send when
the new component has been downloaded and an installation
On 2013/07/31 01:31:30, waffles wrote:
> Send -> Sent

Done.

[jvoung (off chromium), 2013-07-31 20:47:08]

looks good from my perspective

What are some of the ideas for the "more events" in future iterations?  Download
progress?

[Sorin Jianu, 2013-07-31 20:51:01]

Download progress could be an event.

At the moment, my thinking is that we would add events as we need to support
additional functionality as needed by the observers.

[cpu_(ooo_6.6-7.5), 2013-07-31 21:49:24]

download progress has been asked by the nacl guys.

[Sorin Jianu, 2013-07-31 21:52:35]

Can we land as is and then iterate one more time to add the download progress
event?

[cpu_(ooo_6.6-7.5), 2013-07-31 21:59:36]

lgtm

Not sure if I like the gmock stuff. I'll let it be lest we get into yet another
gmock never-ending discussion.

I believe that starting and stopping notifications are useless because other
stuff did not materialize.

https://codereview.chromium.org/20774003/diff/20001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/20774003/diff/20001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.h:83: // the current
version. |fingerprint| and |name| are optional.
mention that observer is also optional.

[jvoung (off chromium), 2013-07-31 22:20:40]

On 2013/07/31 21:52:35, Sorin Jianu wrote:
> Can we land as is and then iterate one more time to add the download progress
> event?

I'd be okay with download progress being done separately. Thanks!

[Sorin Jianu, 2013-07-31 22:29:48]

Does that mean that we can remove STARTED and SLEEPING notifications in a future
CL?

I agree with gMocks bringing some maintenance challenges but how do people get
around it? Implementing specific classes to do what the mocks do, in this case a
notification tracker class is not a good idea either.

https://codereview.chromium.org/20774003/diff/20001/chrome/browser/component_...
File chrome/browser/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/20774003/diff/20001/chrome/browser/component_...
chrome/browser/component_updater/component_updater_service.h:83: // the current
version. |fingerprint| and |name| are optional.
On 2013/07/31 21:59:36, cpu (no reviews Aug 1 to 12) wrote:
> mention that observer is also optional.

Done.

[commit-bot: I haz the power, 2013-07-31 22:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/20774003/28001

[commit-bot: I haz the power, 2013-07-31 23:02:13]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sorin Jianu, 2013-07-31 23:11:35]

Antony, I need an owner approval for this CL due to adding a comment in the
chrome\browser\chrome_notification_types.h

[asargent_no_longer_on_chrome, 2013-08-01 00:12:20]

LGTM, but I think you might still end up needing someone from the chrome/OWNERS
file to review. I think running 'git cl presubmit' will tell you.

[commit-bot: I haz the power, 2013-08-01 00:28:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/20774003/28001

[commit-bot: I haz the power, 2013-08-01 00:54:16]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sorin Jianu, 2013-08-01 01:11:52]

Hi sky@ 
I need an owner approval for this CL due to adding a comment in the
chrome\browser\chrome_notification_types.h
Thank you!

[Sorin Jianu, 2013-08-01 16:08:28]

Hi Darin,
I need an owner approval for this CL due to adding a comment in the
chrome\browser\chrome_notification_types.h
Thank you!

[darin (slow to review), 2013-08-01 16:36:03]

LGTM

[commit-bot: I haz the power, 2013-08-01 16:52:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/20774003/28001

[commit-bot: I haz the power, 2013-08-01 19:13:43]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-01 20:28:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sorin@chromium.org/20774003/28001

[commit-bot: I haz the power, 2013-08-01 22:23:45]

Change committed as 215131