DevTools: similarly to the way we match scripts ignoring sourceurl comments, ignore framework-speci…

DevTools: similarly to the way we match scripts ignoring sourceurl comments, ignore framework-specific closure wrappers.

BUG=621535
Committed: https://crrev.com/8afea8f3061288d68aac97a266ea9b2ac9bd72e6
Cr-Commit-Position: refs/heads/master@{#400945}

[pfeldman, 2016-06-20 15:36:13]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-06-20 15:44:36]

Description was changed from

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-spacific closure wrappers.

BUG=621535
==========

to

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-specific closure wrappers.

BUG=621535
==========

[dgozman, 2016-06-20 16:17:42]

Let's add a test.

lgtm

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
(right):

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:327:
var suffix = this._uiSourceCode.workingCopy().substr(this._scriptSource.length);
Should we strip |this._scriptSource.trimRight().length| symbols to be consistent
with previous line?

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:334:
if (workingCopy == nodePrefix + this._scriptSource + nodeSuffix)
===

[pfeldman, 2016-06-21 08:50:46]

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
(right):

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:327:
var suffix = this._uiSourceCode.workingCopy().substr(this._scriptSource.length);
On 2016/06/20 16:17:42, dgozman wrote:
> Should we strip |this._scriptSource.trimRight().length| symbols to be
consistent
> with previous line?

They produce 'opposite' checks, so i'd rather not.

https://codereview.chromium.org/2077363003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:334:
if (workingCopy == nodePrefix + this._scriptSource + nodeSuffix)
On 2016/06/20 16:17:42, dgozman wrote:
> ===

Done.

[pfeldman, 2016-06-21 08:50:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-21 08:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2077363003/#ps20001
(title: "test added")

[commit-bot: I haz the power, 2016-06-21 08:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2077363003/20001

[commit-bot: I haz the power, 2016-06-21 10:44:51]

Description was changed from

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-specific closure wrappers.

BUG=621535
==========

to

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-specific closure wrappers.

BUG=621535
==========

[commit-bot: I haz the power, 2016-06-21 10:44:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 10:47:45]

Description was changed from

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-specific closure wrappers.

BUG=621535
==========

to

==========
DevTools: similarly to the way we match scripts ignoring sourceurl comments,
ignore framework-specific closure wrappers.

BUG=621535

Committed: https://crrev.com/8afea8f3061288d68aac97a266ea9b2ac9bd72e6
Cr-Commit-Position: refs/heads/master@{#400945}
==========

[commit-bot: I haz the power, 2016-06-21 10:47:46]

Patchset 2 (id:??) landed as
https://crrev.com/8afea8f3061288d68aac97a266ea9b2ac9bd72e6
Cr-Commit-Position: refs/heads/master@{#400945}

[paulirish, 2016-09-21 02:47:58]

https://codereview.chromium.org/2077363003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
(right):

https://codereview.chromium.org/2077363003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:332:
var nodePrefix = "(function (exports, require, module, __filename, __dirname) {
\n";
fwiw: this matches against the node string here: 
https://github.com/nodejs/node/blob/66df5d147f65cc1a36098987e2d6131c5403c0fc/...