Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2077363002: [liveedit] simplify source position recalculation. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[liveedit] simplify source position recalculation. When updating source positions, we recompute reloc info. Under the assumption that reloc info is appended to the code, we may or may not need to allocate a new code object. That assumption is no longer valid since 2010 (see r5020). R=mstarzinger@chromium.org Committed: https://crrev.com/ecc760a012d1d440a2dc2c62772e20f35e7edf78 Cr-Commit-Position: refs/heads/master@{#37097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -75 lines) Patch
M src/debug/liveedit.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
4 years, 6 months ago (2016-06-20 09:37:29 UTC) #1
Yang
Michael (L), could you take a look?
4 years, 6 months ago (2016-06-20 09:54:42 UTC) #3
Michael Lippautz
lgtm
4 years, 6 months ago (2016-06-20 10:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077363002/1
4 years, 6 months ago (2016-06-20 10:27:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 10:55:15 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ecc760a012d1d440a2dc2c62772e20f35e7edf78 Cr-Commit-Position: refs/heads/master@{#37097}
4 years, 6 months ago (2016-06-20 10:57:42 UTC) #9
Michael Starzinger
4 years, 5 months ago (2016-06-27 11:27:56 UTC) #10
Message was sent while issue was closed.
LGTM. Woot. Love it. Thanks!

Powered by Google App Engine
This is Rietveld 408576698