Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2077353004: [heap] Filter out stale left-trimmed handles for scavenges (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Filter out stale left-trimmed handles for scavenges The missing part from https://codereview.chromium.org/2078403002/ R=jochen@chromium.org BUG=chromium:621869 LOG=N Committed: https://crrev.com/7a88ff3cc096ecd681e9d10ad0a75c7d3daf027e Cr-Commit-Position: refs/heads/master@{#37184}

Patch Set 1 #

Patch Set 2 : Fix use in scavenge (deal with forwarding pointers) #

Patch Set 3 : Add regression test #

Patch Set 4 : Revert "[heap] Filter out stale left-trimmed handles" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -74 lines) Patch
M src/heap/heap.h View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M src/heap/scavenger.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-620553.js View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D test/mjsunit/regress/regress-621869.js View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Michael Lippautz
ptal; until we come up with something better we also need to filter them for ...
4 years, 6 months ago (2016-06-21 11:25:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353004/1
4 years, 6 months ago (2016-06-22 08:35:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3605) v8_mac_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-22 08:55:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353004/40001
4 years, 6 months ago (2016-06-22 11:43:55 UTC) #8
jochen (gone - plz use gerrit)
hum hum, so now you just filter those out at a different point. Wasn't Hannes ...
4 years, 6 months ago (2016-06-22 11:55:56 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-22 11:57:51 UTC) #10
Michael Lippautz
On 2016/06/22 11:55:56, jochen wrote: > hum hum, so now you just filter those out ...
4 years, 6 months ago (2016-06-22 11:59:57 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 12:12:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353004/40001
4 years, 6 months ago (2016-06-22 12:18:44 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 12:21:25 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 12:22:53 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a88ff3cc096ecd681e9d10ad0a75c7d3daf027e
Cr-Commit-Position: refs/heads/master@{#37184}

Powered by Google App Engine
This is Rietveld 408576698