chrome_elf/elf_imports_unittest.cc - Issue 2077323004: Remove dependency on base/win/win_util.cc from crashpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/elf_imports_unittest.cc

Issue 2077323004: Remove dependency on base/win/win_util.cc from crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Dont run the ELFImportsTest for component builds Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/elf_imports_unittest.cc

diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc

index 8c3527a13858f5c2e476b3efbfb3655e400ea7d9..3aa03ad06fea0f26fd829c6830a3cda12cf19591 100644

--- a/chrome_elf/elf_imports_unittest.cc

+++ b/chrome_elf/elf_imports_unittest.cc

@@ -62,7 +62,7 @@ class ELFImportsTest : public testing::Test {

// If you break this test, you may have changed base or the Windows sandbox

// such that more system imports are required to link.

-#ifdef NDEBUG

+#if defined(NDEBUG) && !defined(COMPONENT_BUILD)

scottmg 2016/06/20 19:47:53 Mention that this is for DrMemory in the CL descri

ananta 2016/06/20 19:50:50 Done.

TEST_F(ELFImportsTest, ChromeElfSanityCheck) {

base::FilePath dll;

ASSERT_TRUE(PathService::Get(base::DIR_EXE, &dll));

« chrome_elf/chrome_elf.gyp ('K') | « chrome_elf/chrome_elf.gyp ('k') | components/crash/content/app/crashpad.cc » ('j') | no next file with comments »