third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html - Issue 2077323003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

Issue 2077323003: Support legacy offerToReceiveAudio/offerToReceiveVideo fields in RTCOfferOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-promise.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

index 5ef08ee58af270348a1f061d2e53855f95222e54..3e595a0dd1ee82d1b6ce39de4e56e81f9a9ddd11 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

@@ -8,8 +8,9 @@

description("Tests RTCPeerConnection createOffer.");

// Note: createOffer() calls in the test runner are successful if the

-// voiceActivityDetection and iceRestart options are passed with a value of true.

-// In all other cases, createOffer() fails in the test runner.

+// voiceActivityDetection and iceRestart options are passed with a value of true

+// and offerToReceiveAudio and offerToReceiveVideo are passed with a positive

+// value. In all other cases, createOffer() fails in the test runner.

var pc = null;

@@ -55,7 +56,7 @@ function expectedCreateOfferFailed4(error) {

window.error = error;

shouldBe('error.name', '"OperationError"');

shouldBe('error.toString()', '"OperationError: TEST_ERROR"');

- shouldNotThrow("pc.createOffer(createOfferSucceeded2, unexpectedCallback, {iceRestart:true});");

+ shouldNotThrow("pc.createOffer(createOfferSucceeded2, unexpectedCallback, {iceRestart:true, offerToReceiveAudio:1, offerToReceiveVideo:1});");

}

function expectedCreateOfferFailed3(error) {

@@ -112,7 +113,7 @@ function testExecutionOrderClosedConnection()

shouldNotThrow('testExecutionOrderClosedConnection()');

pc = new webkitRTCPeerConnection(null);

-shouldNotThrow('pc.createOffer(createOfferSucceeded1, unexpectedCallback, {voiceActivityDetection:true, iceRestart:true});');

+shouldNotThrow('pc.createOffer(createOfferSucceeded1, unexpectedCallback, {voiceActivityDetection:true, iceRestart:true, offerToReceiveAudio:1, offerToReceiveVideo:1});');

window.jsTestIsAsync = true;

window.successfullyParsed = true;