Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2077233002: Flip Win GPU, Angle builders to GN. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mb_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Win GPU, Angle builders to GN. Now that most of the Win builders are using GN instead of GYP these should be, too. R=kbr@chromium.org, jmadill@chromium.org BUG=605318 Committed: https://crrev.com/400201d7327b4ed73f5d31d8968be30c1daa70a1 Cr-Commit-Position: refs/heads/master@{#401185}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-19 02:20:58 UTC) #1
Jamie Madill
these all lgtm
4 years, 6 months ago (2016-06-19 17:11:51 UTC) #2
Jamie Madill
(although I don't know is Mac is very well tested with GN)
4 years, 6 months ago (2016-06-19 17:12:15 UTC) #3
Dirk Pranke
On 2016/06/19 17:12:15, Jamie Madill wrote: > (although I don't know is Mac is very ...
4 years, 6 months ago (2016-06-19 17:38:28 UTC) #4
Ken Russell (switch to Gerrit)
Awesome! LGTM It would be great if the mixins were refactored so that changing e.g. ...
4 years, 6 months ago (2016-06-21 22:23:12 UTC) #5
Dirk Pranke
On 2016/06/21 22:23:12, Ken Russell wrote: > It would be great if the mixins were ...
4 years, 6 months ago (2016-06-21 22:28:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077233002/20001
4 years, 6 months ago (2016-06-21 22:34:32 UTC) #9
Jamie Madill
Just as a heads up, I tried compiling gles2_conform_test locally with GN on Widows and ...
4 years, 6 months ago (2016-06-21 22:43:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/91386)
4 years, 6 months ago (2016-06-22 00:06:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077233002/20001
4 years, 6 months ago (2016-06-22 01:41:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 03:08:01 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 03:11:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/400201d7327b4ed73f5d31d8968be30c1daa70a1
Cr-Commit-Position: refs/heads/master@{#401185}

Powered by Google App Engine
This is Rietveld 408576698