Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: BUILD.gn

Issue 2077173002: Windows GN build flag fixes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 03e05310eba24cdea847817908d5be91a4b365b6..69bebe19363da07b8ea73bb2f09d95aec0332966 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -164,6 +164,7 @@ config("toolchain") {
defines = []
cflags = []
+ ldflags = []
if (v8_target_cpu == "arm") {
defines += [ "V8_TARGET_ARCH_ARM" ]
@@ -269,16 +270,22 @@ config("toolchain") {
}
if (v8_target_cpu == "x86") {
defines += [ "V8_TARGET_ARCH_IA32" ]
+ if (is_win) {
+ # Ensure no surprising artifacts from 80bit double math with x86.
+ cflags += [ "/arch:SSE2" ]
+ }
}
if (v8_target_cpu == "x64") {
defines += [ "V8_TARGET_ARCH_X64" ]
+ if (is_win) {
+ # Incrase the initial stack size. The default is 1MB, this is 2MB. This
Michael Achenbach 2016/06/20 11:59:21 nit: Increase
+ # applies only to executables and shared libraries since ldflags are not
+ # pushed to dependants.
+ ldflags = [ "/STACK:2097152" ]
Michael Achenbach 2016/06/20 11:59:21 += as it is defined above.
+ }
}
- if (is_win) {
- defines += [ "WIN32" ]
- # TODO(jochen): Support v8_enable_prof.
- }
-
+ # TODO(jochen): Support v8_enable_prof on Windows.
# TODO(jochen): Add support for compiling with simulators.
if (is_debug) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698